Thanks to visit codestin.com
Credit goes to github.com

Skip to content

IronQueue now respects ssl_verifypeer settings to disable SSL check#4141

Merged
taylorotwell merged 1 commit into
laravel:4.1from
JamShady:pull-request/iron-mq-disable-ssl-verification
Apr 18, 2014
Merged

IronQueue now respects ssl_verifypeer settings to disable SSL check#4141
taylorotwell merged 1 commit into
laravel:4.1from
JamShady:pull-request/iron-mq-disable-ssl-verification

Conversation

@JamShady
Copy link
Copy Markdown
Contributor

Iron-IO fails on some setups due to SSL verification checks. According to their documentation, one of the ways to work around this issue is to set ssl_verifypeer = false.

This update allows for that change to be made from the laravel configuration

@JoostK
Copy link
Copy Markdown
Contributor

JoostK commented Apr 15, 2014

In my opinion allowing for such hacks is not the way to go. It sure is the easiest, but not a real solution. With proper SSL certificates you should always be able to solve such issues, for real.

@JamShady
Copy link
Copy Markdown
Contributor Author

It's one of the official proposed solutions, and there appears to be no
workaround for my particular configuration.

It's either making this a configurable option, or making a nastier hack in
the codebase

taylorotwell added a commit that referenced this pull request Apr 18, 2014
…sl-verification

IronQueue now respects ssl_verifypeer settings to disable SSL check
@taylorotwell taylorotwell merged commit 280f527 into laravel:4.1 Apr 18, 2014
@taylorotwell
Copy link
Copy Markdown
Member

I'm OK with this being a configurable option if people want. As long as it doesn't default to something less secure.

@JamShady JamShady deleted the pull-request/iron-mq-disable-ssl-verification branch April 18, 2014 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants