[4.2] Enable easier usage of error_log in Log\Writer#4406
Merged
Conversation
taylorotwell
added a commit
that referenced
this pull request
May 13, 2014
[4.2] Enable easier usage of error_log in Log\Writer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many setups you want to use the centralized
error_logfunction in PHP to log errors and the like, so I added a quick helper method to do this.The
$messageTypeparameter corresponds to $message_type as found in theerror_logdocumentation on php.net. The default behaviour is to use the default OS log, but there is an option to use the SAPI log which will, for example, let Apache2 decide where errors should be logged. This may be a more sensible default and a more recommended setup, but I figured sticking with default PHP and Monolog behaviour was best.Also refactored the
new LineFormatterinto its own method as it was being re-used in several methods.