[12.x] Ensure related models is iterable on HasRelationships@relationLoaded()
#55519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does solve #55518, but personally I think you should add a new test case to ensure that this doesn't regress |
|
@danharrin thanks for reviewing it. I just added a test case |
shaedrich
reviewed
Apr 23, 2025
nicekiwi
reviewed
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55518
PR #55471 introduced changes to the
HasRelationships@relationLoaded()to improve performance.It introduced an oversight when loading nesting relations assuming all relations would return am iterable (e.g.
Collection). That is the case for some relations, such asHasMany.But not the case for relations such as
BelongsTo,HasOne,MorphOne, which return a single model.So when iterating one of these relations, the
foreachworks iterating through theModelinstance public properties such asincrementing,exists, ...This PR:
foreach