-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[12.x] Typed getters for Arr helper #55567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can't these methods be put into a trait which just calls the implementing class' |
Possibly. It's a little icky because the exception error message specifically reference the 'type' that is being accessed (e.g. 'configuration keys' vs 'array keys'). Solving that either means changing the exception errors even on the Config class (possibly breaking), or adding a helper function that each using class would have to implement to identify the 'type' of content being accessed. If the thought was that this could be used elsewhere, it might be worth doing. An earlier attempt at making wide "Typeable" objects didn't go anywhere though (#51302), so I kept this as simple and to-the-point as possible. |
Ah, I didn't know the Typeable PR—thanks for linking it 👍🏻 Yeah, what you mentioned makes this possibly tricky—perhaps too tricky to be a good and feasible alternative |
Maybe it makes sense to make this available for |
Adds typed getter helpers (
Arr::string()
,Arr::integer()
,Arr::float()
,Arr::boolean()
,Arr::array()
) as also exist on theConfig
facade, in an effort to make static analysis easier when using theArr::get()
helper (including tests).Documentation PR: laravel/docs#10354