Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove @internal Annotation from $components Property in InteractsWithIO #55580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

michaelnabil230
Copy link
Contributor

Summary:

This PR removes the @internal annotation from the $components property in the InteractsWithIO. The change was made to allow more flexibility for users extending the console components factory.

Reasoning:

The @internal annotation suggested that this property was not meant to be accessed or overwritten outside the framework. However, after evaluating the use case and feedback from the community, it seems that exposing this property could be beneficial for custom console component handling, making it a more flexible option for developers.

Impact:

  • Developers who need to extend or modify the console components factory can now safely interact with the $components property.
  • No breaking changes are expected, as this is a documentation change to the visibility of the property.

@taylorotwell taylorotwell merged commit 17a53e1 into laravel:12.x Apr 28, 2025
60 checks passed
@michaelnabil230 michaelnabil230 deleted the remove-doc-internal branch April 28, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants