Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[12.x] Support predis/predis 3.x #55641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

gabrielrbarbosa
Copy link
Contributor

@AndrewMast
Copy link
Contributor

Does predis 3.0.0 not introduce any breaking changes? From what I can see in the release notes of 2.4.0 and 3.0.0 (Laravel is still using 2.3.0), there were quite a few changes.

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also necessary to update src/Illuminate/Redis/composer.json.

@gabrielrbarbosa
Copy link
Contributor Author

@AndrewMast from their changelog it seems that only new features from Redis 8 is now available, but couldn't find any mention of breaking changes

@gabrielrbarbosa
Copy link
Contributor Author

laravel/horizon could also allow predis 3.x here

@gabrielrbarbosa
Copy link
Contributor Author

@taylorotwell May I also update this references to redis 8.0? Or is it better to open another PR for that?

docker-compose.yml
.github/workflows/queues.yml
.github/workflows/tests.yml
https://github.com/search?q=repo%3Alaravel%2Fframework%20redis%3A7.0&type=code

@GrahamCampbell
Copy link
Member

No, we want to test the lowest supported version.

@taylorotwell taylorotwell merged commit 2ca51e4 into laravel:12.x May 5, 2025
58 checks passed
@GrahamCampbell
Copy link
Member

Some corrections: #55654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for predis v3.0.0
4 participants