fix: Helper function secure_url not always returning a string #56807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #56806
Also added a test for both scenarios. Rollback my change on 896 and watch it fail.
Main issue is we allow anything in the path, yet declare a return type of string despite if a null path is passed in, a URLGenerator is returned.
This ensures that a string is always returned.
This does have the implication PRE #56684 whereby users might have been handling a URLGenerator being returned before a string was declared as the return type. Although I expect most users will have been handling strings anyway and if a URL generator was returned doing what I'm doing!
Plus the secure method feels better to utilize here?
cheers