[12.x] Allow mass assignment for value object casting. #56871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Taylor,
I ran into an issue this morning when trying to mass assign an attribute that's a cast that wasn't being guarded.
Given a model that uses a value cast object, that's not explicitly guarded:
I would expect to be able to mass assign the attribute:
However, this was throwing:
Illuminate\Database\Eloquent\MassAssignmentException: Add [address] to fillable property to allow mass assignment on [Illuminate\Tests\Database\Person].
I tried to use the
Model::handleDiscardedAttributeViolationUsing(...)
method added in #44664 to handle that within my app, but wasn't able to since the value that was trying to be set wasn't being passed into the closure. That's probably another update needed to make that hook more useful.After digging into how we determine if an attribute is
isFillable()
or not, I see that we're already checking if the attributehasSetMutator
orhasAttributeSetMutator
so it felt natural to also check if the attributeisClassCastable
.