[12.x] Rename group to messageGroup property
#56919
Conversation
fix #56895 Signed-off-by: Mior Muhammad Zaki <[email protected]>
src/Illuminate/Queue/SqsQueue.php
Outdated
|
|
||
| if (is_null($messageGroup) && isset($job->group) && is_string($job->group)) { | ||
| $messageGroup = $job->group; | ||
| } |
There was a problem hiding this comment.
This is just to prevent breaking changes on any existing queues. We can remove it for 13 release.
There was a problem hiding this comment.
What if the job instance doesn't have the $messageGroup property but instead has a $group property that is not related to Amazon SQS? I believe the same issue we're trying to solve would still exist in that case.
Also, I don't think we need to worry about breaking changes here, since the original PR was only merged 5 days ago.
There was a problem hiding this comment.
- It has to be a FIFO queue on SQS
$grouphas to a string and not unique to be grouped by SQS
the chance of that is minimal to non existent.
There was a problem hiding this comment.
So, we have jobs that have a $group and also a string or hash value. The name $group is too general and will most likely also be used in the app context. Strings can also occur here. In my opinion, a name should simply be chosen that does not conflict with job attributes from the app context. I don't think it's a breaking change to consistently rename it now. The bigger breaking change is the variable $group, which breaks existing applications. There shouldn't be that many people who use the new feature directly in production and would therefore be affected by a change from $group to another name.
There was a problem hiding this comment.
Would using a property name like $_messageGroup solve the issue?
There was a problem hiding this comment.
@Brenneisen are you using SQS FIFO queue at the moment with $group property but doesn't intend to use Fair queue by setting onGroup()?
By default, SQS uses standard queue and not affected by this.
fix #56895