Fix PHP_CLI_SERVER_WORKERS inside laravel/sail #56923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP_CLI_SERVER_WORKERS environment variable did not work correctly in laravel sail due to phpServerWorkers being set to false instead of the set number
| return $workers > 1 && ! $this->option('no-reload') ? false : $workers; | ||
| if ($workers > 1 && | ||
| ! $this->option('no-reload') && | ||
| ! (int) env('LARAVEL_SAIL', 0)) { |
There was a problem hiding this comment.
Question
I'm not a Sail user, but should we use env() here, or would it be better to rely on config() instead?
See
There was a problem hiding this comment.
I used env here for two reasons:
- it was used a couple lines before to retrieve workers configuration
- since this command is used to start the server, it wouldn't really matter over config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #56922 PHP_CLI_SERVER_WORKERS environment variable did not work correctly in laravel sail due to phpServerWorkers being set to false instead of the set number.
In normal environment the logic is preserved, since
LARAVEL_SAILenvironment variable wouldn't be set