[13.x] Use standard SQL escaping for column comments in MySqlGrammar#59473
Draft
JoshSalway wants to merge 2 commits into
Draft
[13.x] Use standard SQL escaping for column comments in MySqlGrammar#59473JoshSalway wants to merge 2 commits into
JoshSalway wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
addslashes()withstr_replace("'", "''", ...)for column comment escaping inMySqlGrammar::modifyComment().Changes
The
modifyComment()method at line 1404 usedaddslashes()to escape column comments, whilecompileTableComment()at line 733 in the same file already correctly usesstr_replace("'", "''", ...). This change makes column-level comments consistent with table-level comments, using standard SQL single-quote escaping throughout.addslashes()escapes with backslashes (\') which is MySQL-specific and can be vulnerable to multi-byte character bypass. SQL-standard escaping ('') is what the rest of the grammar already uses.Test plan
testAddingCommentpasses in both MySqlSchemaGrammarTest and MariaDbSchemaGrammarTestcompileTableComment()at line 733 in the same file