[13.x] Allow scheduler to opt out of pause and interrupt cache checks#60226
Draft
jackbayliss wants to merge 3 commits into
Draft
[13.x] Allow scheduler to opt out of pause and interrupt cache checks#60226jackbayliss wants to merge 3 commits into
jackbayliss wants to merge 3 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Worker class allows you to opt out of the cache checks, this would also nice for the scheduler.
This works for
schedule;work, andschedule:runcommands (work basically calls run)This is particularly useful for
everyXSecondscalls, where you get a considerable amount of cache hits.. and even more useful the more servers you have.This PR gives you the ability to turn them off independently, or as a whole:
I went with the Schedule class cause it makes the most sense discoverability wise in my head.
I've tried to align it with the Worker, but feel free to jazz it up.
This is still useful in general even if you're not using the
Secondevents to avoid the cache hit if you're not using the features.I'm just trying to make everything as efficient as I can atm 🫖