[13.x] Fix path separator encoding in temporaryUrl on local disk#60230
Merged
taylorotwell merged 1 commit intoMay 22, 2026
Merged
Conversation
Contributor
|
Verified this locally, nice one. Yeah, I missed it, am only human after all. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #60194, which fixed the encoding in
temporaryUploadUrlbut missed the identical pattern intemporaryUrlintroduced by #60137.Background
#60137 added
rawurlencode($path)to bothtemporaryUrlandtemporaryUploadUrlso reserved URI characters (?,&,#) in storage keys couldn't escape the path segment of a signed URL.rawurlencodealso encodes/as%2F, so nested storage keys produced URLs that no longer matched the storage serve/upload routes. #60194 fixed this intemporaryUploadUrlwithstrtr(rawurlencode($path), ['%2F' => '/']), but the sibling call site two methods up intemporaryUrlwas left with the barerawurlencode($path).Reproduction
A
GETagainst that URL hits the storage serve route with an encoded key the route can't resolve, so users see a 404 / 403 instead of the file.PHPUnit output before the fix:
Fix
Mirror #60194 — apply the same
strtrdecode step intemporaryUrlso?,&,#stay escaped while/is preserved.After