[14.x] Update Notification::fake() to respect job middleware#60233
Open
ziadoz wants to merge 6 commits into
Open
[14.x] Update Notification::fake() to respect job middleware#60233ziadoz wants to merge 6 commits into
Notification::fake() to respect job middleware#60233ziadoz wants to merge 6 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
b14e5da to
636a81b
Compare
Contributor
Author
|
I think the CI failures here are unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was writing some notifications tests today, and I got tripped up by
Notification::fake(), as it doesn't respect any middleware on the notification job.I've adjusted
NotificationFakeso it now pipes the job through its middleware to determine if it would have been sent to the applicable channels.Did this 14.x because technically it's a breaking change, but I think the current behaviour of having notification middleware ignored can be confusing.