[13.x] battle harden when scheme is present in the config#60237
Open
DGarbs51 wants to merge 3 commits into
Open
[13.x] battle harden when scheme is present in the config#60237DGarbs51 wants to merge 3 commits into
DGarbs51 wants to merge 3 commits into
Conversation
shaedrich
reviewed
May 22, 2026
Comment on lines
265
to
266
| * @param array $options | ||
| * @return string |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param array{host?: mixed, scheme?: mixed} $options | |
| * @return string | |
| * | |
| * @phpstan-return ($options is array{host: string} ? ($options is array{host: non-empty-string} ? string: never) : never) |
or
Suggested change
| * @param array{host?: non-empty-string, scheme?: string} $options | |
| * @return string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the scheme key is set in the redis config it will be appended on to the host, regardless of whether the host includes a scheme or not.
This will ensure schemes match if they are present in both, instead of simply appending and breaking.