[13.x] Fix duplicated socket value in Redis broadcast payload#60238
Open
LucasCavalheri wants to merge 1 commit into
Open
[13.x] Fix duplicated socket value in Redis broadcast payload#60238LucasCavalheri wants to merge 1 commit into
LucasCavalheri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an inconsistency in
RedisBroadcasterwhere thesocketvalue was being included twice in Redis broadcast payloads.
Previously, the payload was constructed like this:
Because the socket was only removed after assigning
$payloadtodata,the resulting payload could contain the socket in both places:
[ 'data' => [ 'id' => 1, 'socket' => '123.456', ], 'socket' => '123.456', ]This behavior diverged from
PusherBroadcaster, which removes the socketfrom the payload data before broadcasting.
Changes
Updated
RedisBroadcasterto remove the socket before building the final payload:Tests
Added
testBroadcastDoesNotIncludeSocketInPayloadDatato verify that:dataFiles Changed
src/Illuminate/Broadcasting/Broadcasters/RedisBroadcaster.phptests/Broadcasting/RedisBroadcasterTest.phpValidation
Result: