[13.x] Allow Jobs to include context#60243
Draft
jackbayliss wants to merge 5 commits into
Draft
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
commented
May 22, 2026
Comment on lines
+22
to
+23
| public readonly array $context = [], | ||
| public readonly ?Carbon $createdAt = null, |
Contributor
Author
There was a problem hiding this comment.
It pained me to not see createdAt last, so just went with it..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use any of the Queue inspect methods ie
reservedJobsetc sometimes... you just want a bit more.. CONTEXTA lot of Jobs you'll just have a generic wrapper, such as a
PodcastJob, it would be very helpful to be able to just get a bit of context when things like deployments are happening which are useful for observability ie so we know more context about that exact job thats holding deployments etc.This adds a
HasContextinterface, that you implement and return an array of what you need in the context() method take below as an example....:This means you can just do...
And instantly, we have more details so I can easily see "Hmm.. this agent is always slow around deployments" etc etc..
The context is saved to the job payload, so it shouldn't be a book, just nice details you need... no idea
Used an interface cause I can't think of a nicer non b/c way unless you're happy to just
method_existsit...I went with context, as it felt right, but open to renaming it.