[5.0] Fix touchOwners() on many to many relationship.#8360
Merged
taylorotwell merged 3 commits intoApr 12, 2015
Conversation
Contributor
|
Considering |
Collaborator
There was a problem hiding this comment.
now this isnull code is running twice
Contributor
There was a problem hiding this comment.
Given instanceof checks, is_null is redundant. This will do:
foreach ($this->touches as $relation)
{
$this->$relation()->touch();
if ($this->$relation instanceof Model)
{
$this->$relation->touchOwners();
}
elseif ($this->$relation instanceof Collection)
{
$this->$relation->each(function (Model $related)
{
$related->touch();
});
}
}And btw I agree that it belongs to the Eloquent\Collection, but as far as I know @taylorotwell didn't want it there?
taylorotwell
added a commit
that referenced
this pull request
Apr 12, 2015
[5.0] Fix touchOwners() on many to many relationship.
flyingL123
added a commit
to flyingL123/framework
that referenced
this pull request
Nov 20, 2017
Solution taken from laravel#8360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we assign many to many relation to
$touchesproperty, we will get an exception on every call fortouchOwners():Call to undefined method Illuminate\Database\Eloquent\Collection::touchOwners().So I iterate on each model within collection to call
touchOwners()method on it instead of collection instance.