Set default charset for sqlsrv driver to utf8 #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
added a commit
that referenced
this pull request
Jun 11, 2015
Set default charset for sqlsrv driver to utf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the framework database configuration, the 'mysql' and 'pgsql' connections default to charset UTF-8. The 'sqlsrv' default connection doesn't specify a default charset.
In many typical default installations of FreeTDS / dblib on Linux, the charset is inadvertently set to something other than UTF-8. As UTF-8 is the preferred default in the vast majority of use cases, it makes sense to hardcode this charset in the 'sqlsrv' connection as well. This avoids having to create a custom database configuration just to set the charset ( see #3417 )