[6.x] Allowing optional use of yml/yaml file extensions in .editorconfig #5090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you send this to 6.0 branch instead? |
Is that the develop branch? There doesn't appear to be a public 6.0 branch? |
|
Ow, sorry. Mistook this with the framework repo 🤦♂ |
GrahamCampbell
approved these changes
Sep 3, 2019
pjona
added a commit
to pjona/lumen
that referenced
this pull request
Sep 16, 2019
Moved changes from Laravel repository - laravel/laravel#5090
fly0305
pushed a commit
to fly0305/Lumen-Framework
that referenced
this pull request
Aug 17, 2022
Moved changes from Laravel repository - laravel/laravel#5090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML docs generally recommends using .yaml as the preferred extension for YAML files - https://yaml.org/faq.html.
I've tweaked the .editorconfig to set both yaml and yml files to have the same indentation. Without this, *.yaml files default to 4 spaces.