[12.x] Add default Redis retry configuration #6666
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mateusjatenee yeah I would extract that match into the framework's Redis facade or something. |
|
@taylorotwell docs PR here: laravel/docs#10787 I kept it very brief, but I can expand if you think it deserves more space. As for this PR, I removed the |
|
Careful with this one @taylorotwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Redis connections to be retried automatically.
The additional configuration is only applied if the
phpredisextension is loaded. It depends on constants that are not available without it — for users running other cache drivers, or running Predis, nothing changes.decorrelated_jitteris used by default to avoid "retry storms" — Here's an AWS articleWith the default configuration, retry delays would be ~300ms, ~600ms, ~1000ms, for a ~2 second total retry window.
This is a bit of a beefy config, mostly because of that
matchstatement — maybe we could pass strings and parse them onframework— that'd also solve having to be careful with calling theRedisnamespace