Use getenv() instead of $_ENV in bootstrap file to ensure environment… #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… variables are accessible
This PR updates the
bootstrap
file to usegetenv()
instead of$_ENV
when retrieving environment variables.In some PHP configurations,
$_ENV
returnsnull
unless thevariables_order
setting inphp.ini
includes theE
flag. This can cause Octane to fail when resolving the application base path or vendor directory.By switching to
getenv()
, Octane can reliably fetch environment variables without requiring users to modify their PHP configuration.Changes
$_ENV['APP_RUNNING_IN_CONSOLE']
withgetenv('APP_RUNNING_IN_CONSOLE')
.COMPOSER_VENDOR_DIR
and other variables are resolved consistently.Why
When extending the Swoole server start process and attempting to change the vendor file path,
$_ENV
returnednull
unlessvariables_order
was explicitly configured. This fix ensures smoother setup for developers across different environments.Impact