Example that fail unicode #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conda virtualenv for Mayavi forces a version of pyface that clashes with sphinx. The manual update of pyface within conda is no longer enough to update to a new version that does not clash with sphinx. Thus the update is forced through pip. Mayavi is an experimentally supported use case of Sphinx-Gallery
|
cc @Eric89GXL (I am never sure whether opening a PR on someone's fork trigger a notification ...) |
|
Yeah I was notified don't worry, just a bit busy today |
No worries, I know I managed to miss a few PR on my fork in the past. Probably due to my github notification settings then ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Eric89GXL This is my very particular use case that still fails after your great work on unicode(sphinx-gallery#106) if you want to give it a try, my other cases seem to work now on py2, thanks. The example runs without problems in python 2 and 3, is thus valid code. And builds in Sphinx-Gallery python 3 master and this branch but fails on python 2 in both cases. Travis is green because the gallery continues to build despite errors, it will stop to be so once sphinx-gallery#97 is merged.
The issue in this example is very particular to my use case, I have latex in the python code. very particular an \uparrow and for lazyness I use raw strings not to need to escape the backslash. But \u means to python that an unicode character is to be interpreted, that's where the problem comes.
Second I have put a patch to make travis pass the test on the mayavi build, the one that has the issue with pygments. It is a problem of the conda virtual environment and the version of pyface(4.4.0) and some of its dependencies. Previously I forced the update of pyface(4.5.0) within conda, but nowt the versions are checked more strickly within conda and pyface does not update, so the update is forced in pip to pyface(5.0.0) It works well enough for our examples.