Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Scrapers with rst #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

lesteve
Copy link

@lesteve lesteve commented Nov 16, 2017

This is a quick and dirty PR whose aim is to show that supporting rst in scrapers is not that crazily difficult.

As it stands the breaking changes are:

  • there is no single img behaviour.
  • different scrapers images are on different lines (I would say this is a good thing although it just happened like this)

I checked that the galleries look similar. I haven't tried to implement a meaningful PNGImageScraper although I suspect that it would not be that different from the one in your PR doc. I think with the rst support you could also add the filename somewhere (e.g. in the figure caption)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants