tests/unit/redux/draftSlice.test.ts (2)

47-63: Consider adding a test for backward compatibility.

The reducer preserves existing links when links is not provided in the payload (line 70 of draftSlice.ts), but there's no test verifying this behavior. This is important since the payload has links?: ProjectLink[] (optional).

📝 Suggested test case

it('should preserve existing links when updating content without links', () => {
  const stateWithDraft = {
    ...initialState,
    notes: {
      'card-123': {
        cardId: 'card-123',
        content: 'Old content',
        links: [{ url: 'https://example.com', type: 'docs' }],
        lastModified: mockNow - 1000,
      },
    },
  }

  // Update content without providing links
  const action = updateDraftNote({
    cardId: 'card-123',
    content: 'Updated content',
    // links intentionally omitted
  })

  const nextState = draftSlice(stateWithDraft, action)

  expect(nextState.notes['card-123']!.content).toBe('Updated content')
  // Links should be preserved
  expect(nextState.notes['card-123']!.links).toEqual([
    { url: 'https://example.com', type: 'docs' },
  ])
})

---

198-227: Consider adding a test for selectDraftLinks selector.

The new selectDraftLinks selector is exported but not tested. Add coverage to ensure it returns the links array or empty array fallback.

📝 Suggested test cases

import {
  // ... existing imports
  selectDraftLinks,
} from '@/lib/redux/slices/draftSlice'

describe('selectDraftLinks', () => {
  it('should return links for specific card', () => {
    const links = [{ url: 'https://example.com', type: 'docs' }]
    const rootState = {
      draft: {
        notes: {
          'card-123': {
            cardId: 'card-123',
            content: 'Test',
            links,
            lastModified: mockNow,
          },
        },
      },
    }

    const selector = selectDraftLinks('card-123')
    expect(selector(rootState)).toEqual(links)
  })

  it('should return empty array for non-existent card', () => {
    const rootState = { draft: initialState }

    const selector = selectDraftLinks('non-existent')
    expect(selector(rootState)).toEqual([])
  })
})

e2e/logged-in/project-info-links.spec.ts (2)

27-44: Consider extracting duplicate openNoteModal helper.

The openNoteModal helper is defined identically in both test describe blocks (lines 27-44 and 460-476). Extract it to the file scope to reduce duplication.

♻️ Suggested refactor

+/**
+ * Helper to open NoteModal from a repo card's Note button
+ */
+async function openNoteModal(
+  page: import('@playwright/test').Page,
+): Promise<import('@playwright/test').Locator> {
+  const card = page.locator('[data-testid^="repo-card-"]').first()
+  await expect(card).toBeVisible({ timeout: 10000 })
+
+  const noteButton = card.getByRole('button', { name: 'Open note' })
+  await expect(noteButton).toBeVisible()
+  await noteButton.click()
+
+  const dialog = page.getByRole('dialog')
+  await expect(dialog).toBeVisible({ timeout: 5000 })
+
+  return dialog
+}
+
 test.describe('ProjectInfo Links (Authenticated)', () => {
   test.use({ storageState: 'e2e/.auth/user.json' })
 
   const BOARD_URL = '/board/board-1'
 
-  /**
-   * Helper to open NoteModal from a repo card's Note button
-   * (Previously opened ProjectInfoModal via overflow menu, now unified into NoteModal)
-   */
-  async function openNoteModal(
-    page: import('@playwright/test').Page,
-  ): Promise<import('@playwright/test').Locator> {
-    // ... implementation
-  }

Also applies to: 460-476

---

98-98: Fixed waitForTimeout calls may introduce flakiness.

Multiple waitForTimeout(200-400) calls are used for waiting on UI updates. While acceptable for E2E tests, these can cause flakiness in slower CI environments. Consider using waitForSelector or expect(...).toBeVisible() with appropriate timeouts instead where feasible.

Also applies to: 129-129, 184-184, 192-192, 216-216, 222-222, 300-300, 362-362, 369-369, 390-390, 531-531, 559-559, 564-564

hooks/board/useNoteModal.ts (1)

121-132: Consider adding error handling in the save function.

The save function calls upsertProjectInfo but doesn't handle potential errors. If the save fails, the caller (NoteModal) won't know unless it catches the propagated exception.

Looking at the NoteModal implementation from the relevant_code_snippets, it appears NoteModal handles errors with try/catch, so this is likely fine. However, you may want to add Sentry logging here for consistency with open().

♻️ Optional: Add error logging

   const save = useCallback(
     async (note: string, links: ProjectLink[]) => {
       if (!cardId) return
 
+      try {
         await upsertProjectInfo(cardId, {
           note,
           comment: '',
           links,
         })
+      } catch (error) {
+        Sentry.captureException(error, { tags: { action: 'saveProjectInfo' } })
+        throw error // Re-throw so caller can handle
+      }
     },
     [cardId],
   )