Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Support inline context for custom and migration events #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

feat: Support inline context for custom and migration events #55

merged 4 commits into from
May 8, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented May 6, 2025 •
edited by jsonbailey
Loading

Support inline-context-all capability

This PR updates the Java SDK to write the full context instead of just context keys for Custom and MigrationOp events.

Changes

  • Modified EventOutputFormatter.java to use writeContext instead of writeContextKeys for Custom events (line 92)
  • Modified EventOutputFormatter.java to use writeContext instead of writeContextKeys for MigrationOp events (line 107)
  • Removed the writeContextKeys method since it's no longer used
  • Updated tests in EventOutputTest.java to expect "context" instead of "contextKeys" in the JSON output
  • Updated contract test capabilities by replacing "inline-context" with "inline-context-all" in TestService.java

Testing

  • All existing tests have been updated and pass

Link to Devin run: https://app.devin.ai/sessions/05607662ac9140fda610b53188918b37
Requested by: [email protected]

Because I added some minor file changes in the common sdk path, release please (RP) tagged a new release for both internal and common. I'm adding the override below after merging RP version bump for internal so that it does not make a version bump for common.
BEGIN_COMMIT_OVERRIDE
chore: Support inline context for custom and migration events
END_COMMIT_OVERRIDE

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner May 6, 2025 16:55
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Original prompt from [email protected]:

Received message in Slack channel #sdks-java:

@Devin I want you to update the java-core repository to write the full context instead of the context keys of the Custom event. It looks like this on line 92 of the EventOutputFormatter.java. We also need to do the same for MigrationOp events on line 107. Make sure you update all relevant tests, this may be the only place writeContextKeys method is used, so cleanup the method if necessary. Make sure to update the contract tests listed capabilities by replacing "inline-context" with "inline-context-all". Make the pr on the branch jb/sdk-1158/support-inline-context-all

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@jsonbailey jsonbailey changed the title Support inline-context-all capability feat: Support inline context for custom and migration events May 6, 2025
@jsonbailey jsonbailey force-pushed the jb/sdk-1158/support-inline-context-all branch from 8a9670f to 04eb96b Compare May 7, 2025 20:19
@jsonbailey
publish the internal package change first
d671921 
Update the docs and simplify the local build enable using a property to disable signing vs commenting it out.
@jsonbailey jsonbailey requested a review from tanderson-ld May 8, 2025 15:08
@jsonbailey jsonbailey merged commit 7a6a1db into main May 8, 2025
14 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1158/support-inline-context-all branch May 8, 2025 16:21
This was referenced May 8, 2025
Closed
Merged
jsonbailey pushed a commit that referenced this pull request May 8, 2025
@github-actions
chore(main): release launchdarkly-java-sdk-internal 1.4.0 (#60)
aea04ac 
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](launchdarkly-java-sdk-internal-v1.3.0...launchdarkly-java-sdk-internal-1.4.0)
(2025-05-08)


### Features

* Support inline context for custom and migration events
([#55](#55))
([7a6a1db](7a6a1db))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsonbailey jsonbailey jsonbailey left review comments

@tanderson-ld tanderson-ld tanderson-ld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsonbailey @tanderson-ld