Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adapt to upcoming breaking API change in Lavalink for DAVE#42

Closed
freyacodes wants to merge 1 commit into
mainfrom
dave
Closed

Adapt to upcoming breaking API change in Lavalink for DAVE#42
freyacodes wants to merge 1 commit into
mainfrom
dave

Conversation

@freyacodes

Copy link
Copy Markdown
Member

Not tested yet, but could be used together with lavalink-devs/Lavalink#1190

val update = event.current
if (update.userId != update.client.selfId) return@on Mono.empty()
val channel = update.channelId.getOrNull()
channelId.set(channel?.asString())

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless we can guarantee the order of these events I have doubts about this working

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah me too, but it was worth trying. Anyways, I'm going to close this PR since #43 looks more polished

@freyacodes freyacodes closed this Feb 24, 2026
@duncte123

Copy link
Copy Markdown
Collaborator

I pulled your changes into #43 and made a few tweaks to ensure it handles multi-guild support properly. That's why I'm closing this branch in favour of the new one (totally didn't notice you already made one)

@freyacodes

Copy link
Copy Markdown
Member Author

I see yeah. It's customary to write something like Co-authored-by: Freya Arbjerg <[email protected]> in the commit message for proper attribution

@duncte123

Copy link
Copy Markdown
Collaborator

I see yeah. It's customary to write something like Co-authored-by: Freya Arbjerg <[email protected]> in the commit message for proper attribution

I am so sorry I forgot that yesterday, rebased the history in that branch to include you. Thanks for the reminder <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants