WASM, WASM_X64: Support shift operations #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready. Please possibly review and share feedback. |
|
This PR might fail after merging of #1481. As the test |
certik
approved these changes
Jan 31, 2023
8c05a06 to
cc0a7e0
Compare
|
All tests passed and I now rebased on top of the latest master. |
certik
approved these changes
Jan 31, 2023
BitRShift is currently signed/arithmetic right shift. This is similar to LLVM Backend.
cc0a7e0 to
177a12d
Compare
|
The tests should hopefully pass now. The new commits X86Assembler: Implement SHL and SAR Instructions and |
|
I am adding this to auto-merge as it seems approved. I will support changes/updates suggested (if any) for recently added commits in a new PR. |
|
Yes, this is good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of
left shiftandright shiftoperations in thewasmandwasm_x64backends. Forright shift, I currently usedsigned/arithmeticright shift operation (this seems similar to thellvmbackend). Other possibility is usingunsigned/logicalright shift operation.