-
Notifications
You must be signed in to change notification settings - Fork 172
Fix some edge cases for compile time operations of % operator #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
On master - On branch - |
|
@czgdp1807 is the latest commit regarding comments fine ? |
|
Please mark your PR ready for review whenever you feel its ready. |
czgdp1807
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the tests for it as well.
|
@Thirumalai-Shaktivel . Could you help me to resolve the conflicts here. Locally I didn't get any conflicts, neither did |
|
You simply had to,
|
Thanks, I'll keep this in mind. My apologies on using |
|
This pull request is now ready for review. |
Fixes #1562
On master -
On branch -