Add support for for-else #1711
Draft
Add support for for-else #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for_else/break_in_if.py currently does not pass.
This fix is due to commit 35a8d86.
|
@thebesttv I am really sorry, we somehow totally missed this PR. Next time please don't hesitate to ping us if we forget. We usually are pretty good about that. Also when the PR is ready, as this one seems, go ahead and mark it "Ready for review". I think what you implemented one approach --- a separate node that gets transformed via ASR->ASR pass. Why not adding a new member to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at adding support for for-else (issue #1442, according to czgdp1807's comment).
A new ASR node
ForElseis added. Invisit_For()atpython_ast_to_asr.cpp, loops with non-zeron_orelseare converted toForElse.An ASR pass
"for_else", &pass_replace_forelse}is added, which consists of two steps:ForElseVisitor:ForElseis visited and converted toDoLoopwith an initial assignment to a boolean flag variable (_no_break_N), and anIfblock at the end that executesorelseas long as the flag remains true. The flag variable corresponding to theDoLoopis recorded indoLoopFlagMap.ExitVisitor:Exitis visited, and its enclosingDoLoopis recorded in a stack. If anExitis found, and the enclosingDoLoopis originally aForElse, the corresponding flag is set to false.Some tests are added, under
tests/for_else.