Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pickle: Hide "numpy" module unless --with-intrinsic-mods is used #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Jun 12, 2023

fixes #1893

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jun 12, 2023

It seems that this issue lfortran/lfortran#1805 (comment) is being experienced here at LPython as well. I guess there is some issue at GitHub's end?

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jun 12, 2023

Ready.

@ubaidsk ubaidsk requested a review from certik June 12, 2023 23:03
@ubaidsk ubaidsk changed the title Pickle: Hide numpy by default Pickle: Hide "numpy" module unless --with-intrinsic-mods is used Jun 12, 2023
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good. Maybe later we can simply mark the "numpy" ASR Module as intrinsic as well, so the checks will simplify. For now this is good, thanks!

@certik certik merged commit b1fb2cf into lcompilers:main Jun 12, 2023
@ubaidsk ubaidsk deleted the hide_numpy_by_default branch June 13, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the "numpy" module unless --with-intrinsic-mods is used
2 participants