use istitle , isalpha on string literal #2380

Agent-Hellboy · 2023-10-14T11:26:29Z

src/lpython/semantics/python_ast_to_asr.cpp

certik · 2023-10-14T14:05:05Z

src/lpython/semantics/python_ast_to_asr.cpp

@@ -6681,7 +6681,7 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
            /*
                String Validation Methods i.e all "is" based functions are handled here
            */
-            std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space"};  // Database of validation methods supported
+            std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space","alpha","title"};  // Database of validation methods supported


Suggested change

std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space","alpha","title"}; // Database of validation methods supported

std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space", "alpha", "title"}; // Database of validation methods supported

certik · 2023-10-14T14:05:26Z

src/lpython/semantics/python_ast_to_asr.cpp

@@ -6949,7 +6949,7 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
                * islower() method is limited to English Alphabets currently
                * TODO: We can support other characters from Unicode Library
            */
-            std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space"};  // Database of validation methods supported
+            std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space","alpha","title"};  // Database of validation methods supported


Suggested change

std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space","alpha","title"}; // Database of validation methods supported

std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space", "alpha", "title"}; // Database of validation methods supported

certik · 2023-10-14T14:05:37Z

src/lpython/semantics/python_ast_to_asr.cpp

@@ -6998,6 +6998,60 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
                tmp = ASR::make_LogicalConstant_t(al, loc, is_lower,
                        ASRUtils::TYPE(ASR::make_Logical_t(al, loc, 4)));
                return;
+            } else if(attr_name == "isalpha") {


Suggested change

} else if(attr_name == "isalpha") {

} else if (attr_name == "isalpha") {

certik · 2023-10-14T14:06:00Z

src/lpython/semantics/python_ast_to_asr.cpp

+                * Specification:
+                * Return True if all characters in the string are alphabetic (letters), and False otherwise.
+                */
+               bool is_alpha = true;


Suggested change

bool is_alpha = true;

bool is_alpha = true;

certik · 2023-10-14T14:06:26Z

src/lpython/semantics/python_ast_to_asr.cpp

+                tmp = ASR::make_LogicalConstant_t(al, loc, is_alpha,
+                        ASRUtils::TYPE(ASR::make_Logical_t(al, loc, 4)));
+                return;
+            } else if(attr_name == "istitle") {


Suggested change

} else if(attr_name == "istitle") {

} else if (attr_name == "istitle") {

certik · 2023-10-14T14:06:37Z

src/lpython/semantics/python_ast_to_asr.cpp

+                bool is_title = true;
+                int length = s_var.length();
+                if (length == 0) {
+                    is_title =false;  


Suggested change

is_title =false;

is_title = false;

ubaidsk · 2023-10-14T16:36:45Z

src/lpython/semantics/python_ast_to_asr.cpp

+                for (auto &ch : s_var) {
+                    if ((ch == ' ' || ch == '\t' || ch == '\n') && word_start) {
+                        continue; 
+                    } else if (std::isalpha(ch) && (std::isupper(ch))) {
+                        only_whitespace = false;
+                        if (word_start) {
+                            word_start = false;
+                        } else {
+                            is_title=false;  
+                        }
+                    } else if (std::isalpha(ch) && (std::islower(ch))) {
+                        only_whitespace = false;
+                        if (word_start) {
+                            is_title=false;  
+                        }
+                        word_start = false;
+                    } else {
+                        word_start = true;
+                    }
+                }


I am slightly concerned about the logic we use here. I wonder if it could be simplified.

Sure, it can be , I will try tomorrow morning.

Hi @Shaikh-Ubaid,

actually we handling 3 flags in here that's why we have complex branching

if ((ch == ' ' || ch == '\t' || ch == '\n') && word_start) { continue;

we need the only_whitespace flag to tack if all character inside the string is whitespace only so that we can mark the below example as false

(lp) ➜ lpython git:(redo_ismethods) python3 Python 3.10.2 | packaged by conda-forge | (main, Mar 8 2022, 15:52:47) [Clang 11.1.0 ] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> " ".istitle() False >>> " H".istitle() True >>> " \n".istitle() False >>> " \t".istitle() False >>> " \r".istitle() False

we need word_start to mark it true if a non-alpha char is found so that we can check if the next word is the title case

(lp) ➜ lpython git:(redo_ismethods) ✗ python3 Python 3.10.2 | packaged by conda-forge | (main, Mar 8 2022, 15:52:47) [Clang 11.1.0 ] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> "Hello\rRock".istitle() True >>> "Hello\nRock".istitle() True >>> "Hello'Rock".istitle() True

and we need is_ttile to store the response

I think we can somehow merge the 2 branches into one but for simplicity, we should keep these separate
I have added comments to the code

ubaidsk · 2023-10-14T16:40:15Z

src/lpython/semantics/python_ast_to_asr.cpp

+                * Specification: Return True if the string is in title case, where the first
+                * letter of each word is capitalized and the rest are lowercase. Return False
+                * if the string is empty or does not meet the title case criteria.


I would mention here which specific characters the istitile() ignores/skips. I would also share two examples here about some (small) sentences (couple of words with spaces and special character) and what istitle() would return for them.

... does not meet the title case criteria.

Or I would share about the title case critera (possibly using example(s).

Added few lines

ubaidsk · 2023-10-14T16:42:08Z

This looks good to me @Agent-Hellboy! Thank you so much for the contributions! Can you add some tests for the istitile() and isalpha() on compile time strings? (I think the tests refactored in this PR are for runtime strings.)

Agent-Hellboy · 2023-10-15T03:39:00Z

Can you add some tests for the istitile() and isalpha() on compile time strings? (I think the tests refactored in this PR are for runtime strings.)

Hi @Shaikh-Ubaid, I didn't understand much, so the test added in test_str_attribute is for execution happening at asr, I guess that's compile time, for runtime where do I need to add those tests?

Thirumalai-Shaktivel · 2024-03-05T12:15:18Z

@Agent-Hellboy What is the status of this PR?
Resolve the conflicts and reviews. After that mark it as Ready for review.

We can add both compile time and run time in the same test.
Example:

"abc".istitle() # compile time
s: str = "abc"
s.istitle() # runtime

I think @Shaikh-Ubaid suggested to keep the test removed from test_str_01.py

Agent-Hellboy · 2024-03-05T15:19:39Z

@Agent-Hellboy What is the status of this PR? Resolve the conflicts and reviews. After that mark it as Ready for review.

We can add both compile time and run time in the same test. Example:
"abc".istitle() # compile time
s: str = "abc"
s.istitle() # runtime
I think @Shaikh-Ubaid suggested to keep the test removed from test_str_01.py

sure, let me do it.

As a workaround for lcompilers#2455.

See this issue for possibly removing Const, which would avoid this error: lfortran/lfortran#3374

Towards lcompilers#2455.

)

* Add semantic error for float declaration & added tests for the same.

Replaced the mistakenly added `gcc` with `g++`.

1. Updated the installation instructions referring to the documentation. 2. Reviewed the complete README and fixed sentences and grammar wherever required.

…les. (lcompilers#2540) * Added `flex` and `zstd-static=1.5.5` packages. * Added `flex` and `zstd-static=1.5.5` packages. * Incorporated suggestions from lcompilers#2537 Moved global package installations to conda environment. * Updated README.md to reflect changes suggested in lcompilers#2537 * Remove `flex` * Remove `flex`

…compilers#2524)

…s#2565)

Agent-Hellboy · 2024-03-05T16:32:31Z

Hi @Thirumalai-Shaktivel
Actually I made a fresh clone and fetched the PR and have made some changes, now I am stuck in a git issue.

git pull myclone main
From https://github.com/Agent-Hellboy/lpython
 * branch                main       -> FETCH_HEAD
 * [new branch]          main       -> myclone/main
Current branch redo_ismethods is up to date.

as you can see redo_ismethods is in sync still i am getting the below error

git push myclone redo_ismethods
Username for 'https://github.com': Agent-Hellboy
Password for 'https://[email protected]':
To https://github.com/Agent-Hellboy/lpython.git
 ! [rejected]            redo_ismethods -> redo_ismethods (non-fast-forward)
error: failed to push some refs to 'https://github.com/Agent-Hellboy/lpython.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. If you want to integrate the remote changes,
hint: use 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Agent-Hellboy added 2 commits October 14, 2023 16:54

use istitle , isalpha on string literal

059fb0e

fix test

c3deff9

ubaidsk reviewed Oct 14, 2023

View reviewed changes

src/lpython/semantics/python_ast_to_asr.cpp Outdated Show resolved Hide resolved

resolve comments

d8b9736

certik reviewed Oct 14, 2023

View reviewed changes

resolve comments

b7b6243

ubaidsk reviewed Oct 14, 2023

View reviewed changes

Resolve comments

a41041e

Improve function doc

e57c7fa

Thirumalai-Shaktivel marked this pull request as draft March 5, 2024 12:15

OmarMesqq and others added 10 commits March 5, 2024 21:40

Implement random.seed()

2d0119e

Proper clock initialization stricter tests

d081f05

Added Support for Symbolic func attribute (lcompilers#2367)

1e9e269

Fixed printing elements from a symbolic list

a66812c

Implemented query methods for log and exp class

0dd0e0b

Removed ExpQ

cc9158b

Implemented symbolic constant E

aa6df70

Added tests

4a4f977

Fixed tests

41361cf

Implemented ASR checks for function dependencies (lcompilers#2167)

293e12b

certik and others added 29 commits March 5, 2024 21:42

CI: Disable C tests on macOS

51decc8

As a workaround for lcompilers#2455.

Fix a bug in Const[int]

8762d11

See this issue for possibly removing Const, which would avoid this error: lfortran/lfortran#3374

CI: Remove more tests on macOS

662a2e9

Towards lcompilers#2455.

CI: Enable LLVM and C backends on macOS

b40c654

Improving prefix-string parsing (fixes lcompilers#2339) (lcompilers#2511

cfacf1e

)

Ignored warnings for inbuilt pow test

c6de400

Fixes isspace edge case

f789c91

Added test for isspace, fixed similar issue in ast_to_asr

cff00a2

Typo fix

b03da1d

Add test for constant empty string

7f7f388

Added case to support log instances in mrv function

6a11d34

Added semantic error for float declaration. (lcompilers#2529)

a9eff5c

* Add semantic error for float declaration & added tests for the same.

Fixed visit_if for SymbolicCompare cases

19001d6

Added a step-by-step documentation for installing and building LPython.

15c7707

Fixed a typo

028efa6

Replaced the mistakenly added `gcc` with `g++`.

Update installation instructions

ce565a5

1. Updated the installation instructions referring to the documentation. 2. Reviewed the complete README and fixed sentences and grammar wherever required.

refine input file missing msg (lcompilers#2536)

72dd7ff

Improved str.count() algorithm using Knuth-Morris-Pratt

24c8d3c

Added implementation for constant strings and tests for str.count

c946cda

refine testcase for random

5b9d0fd

Refactor string attributes and add constant string implementations (l…

f5a772c

…compilers#2524)

Remove submodule lpython (lcompilers#2548)

b7a1ebc

updated cmake version for windows

036d888

Fixing symbolic pass according to error caught in LFortran (lcompiler…

6c2340e

…s#2565)

Implemented numpy.hypot

29efe10

use istitle , isalpha on string literal

c72d507

resolve comments

29ee579

Update references

a015d76

	std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space","alpha","title"}; // Database of validation methods supported
	std::vector<std::string> validation_methods{"lower", "upper", "decimal", "ascii", "space", "alpha", "title"}; // Database of validation methods supported

	} else if(attr_name == "isalpha") {
	} else if (attr_name == "isalpha") {

	} else if(attr_name == "istitle") {
	} else if (attr_name == "istitle") {

use istitle , isalpha on string literal #2380

Are you sure you want to change the base?

use istitle , isalpha on string literal #2380

Uh oh!

Conversation

Agent-Hellboy commented Oct 14, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Agent-Hellboy Oct 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk commented Oct 14, 2023

Uh oh!

Agent-Hellboy commented Oct 15, 2023

Uh oh!

Thirumalai-Shaktivel commented Mar 5, 2024

Uh oh!

Agent-Hellboy commented Mar 5, 2024

Uh oh!

Agent-Hellboy commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Agent-Hellboy Oct 15, 2023 •

edited

Loading

Agent-Hellboy commented Mar 5, 2024 •

edited

Loading