Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing symbolic compare for test_gruntz.py #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fixing symbolic compare for test_gruntz.py #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6613bf
Fixing symbolic compare for test_gruntz.py
anutosh491 Feb 6, 2024
59599c4
Added tests
anutosh491 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions integration_tests/test_gruntz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,28 @@
from sympy import Symbol

def mmrv(e: S, x: S) -> list[S]:
l: list[S] = []
if not e.has(x):
return l
list0: list[S] = []
return list0
elif e == x:
list1: list[S] = [x]
return list1
else:
raise

def test_mrv1():
def test_mrv():
# Case 1
x: S = Symbol("x")
y: S = Symbol("y")
ans: list[S] = mmrv(y, x)
assert len(ans) == 0
ans1: list[S] = mmrv(y, x)
print(ans1)
assert len(ans1) == 0

test_mrv1()
# Case 2
ans2: list[S] = mmrv(x, x)
ele1: S = ans2[0]
print(ele1)
assert ele1 == x
assert len(ans2) == 1

test_mrv()
9 changes: 9 additions & 0 deletions src/libasr/pass/replace_symbolic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,15 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
xx.m_test = new_logical_not;
}
}
} else if (ASR::is_a<ASR::SymbolicCompare_t>(*xx.m_test)) {
ASR::SymbolicCompare_t *s = ASR::down_cast<ASR::SymbolicCompare_t>(xx.m_test);
ASR::expr_t* function_call = nullptr;
if (s->m_op == ASR::cmpopType::Eq) {
function_call = basic_compare(xx.base.base.loc, "basic_eq", s->m_left, s->m_right);
} else {
function_call = basic_compare(xx.base.base.loc, "basic_neq", s->m_left, s->m_right);
}
xx.m_test = function_call;
}
}

Expand Down