Freeing variables correctly through visit_Return #2550
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2533
Currently on master as soon as we encountered the return node, we thought it was the end of the program and we could free out everything. But consider the following
Here we can't free the variable
e
till the function reaches an end (As it is being used in the 2nd if block). So as shown in the issue this leads to incorrect resultsThis is now fixed and we get the correct output