Handling leading zeros in integer literals #2568
Conversation
src/lpython/parser/tokenizer.re
Outdated
| // Oct | ||
| s = s + 2; | ||
| uint64_t n = get_value((char*)s, 8, loc); | ||
| u.from_smallint(n); | ||
| } else { | ||
| lex_dec_int_large(al, s, e, u); | ||
| if (s[0] == '0' && u.n != 0) { |
There was a problem hiding this comment.
Hello @hankluo6 ! Thanks for this!
I think this is not the right file to make the changes. Your idea is correct. Please make the same changes in tokenizer.cpp. 👍
Welcome to LPython!
There was a problem hiding this comment.
Hi @kmr-srbh
Thanks for your feedback! I'm excited to be part of LPython! I think tokenizer.cpp is generated from tokenizer.re using re2c so I made change on this file. Please let me know if I'm mistaken.
|
|
|
Oh! I am sorry. @mrdaybird is right. I had tested your changes through the Thanks for the correction @mrdaybird ! |
|
Please mark this PR ready for review once it is ready. |
@Shaikh-Ubaid @Thirumalai-Shaktivel I added a new test, could you review it? Thanks! |
Fixed #2002
I catch this error in the tokenizer because it removes trailing zeros in
lex_int. Also, to handle the case of all zeros, we must allow the tokenizer to process the number first.