Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tests] register tests/expr17.py #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

khushi-411
Copy link
Contributor

As per title.

Thanks for noticing it, @Thirumalai-Shaktivel!

@khushi-411 khushi-411 marked this pull request as draft March 7, 2024 06:56
tests/tests.toml Outdated
Comment on lines 145 to 147
asr = true
ast = true
llvm = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asr = true
ast = true
llvm = true

Let's test only python.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Comment on lines +12 to +14



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excess lines here should not be present. I think this can be handled in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will create another PR for it.

Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue for it here #2583. I think this is good to merge.

Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for this!

@khushi-411 khushi-411 marked this pull request as ready for review March 7, 2024 08:59
@ubaidsk ubaidsk enabled auto-merge (squash) March 7, 2024 09:06
@ubaidsk ubaidsk merged commit 77baa1f into lcompilers:main Mar 7, 2024
@khushi-411 khushi-411 deleted the python_visitor branch March 7, 2024 09:28
hankluo6 pushed a commit to hankluo6/lpython that referenced this pull request Mar 8, 2024
* register tests/expr17.py

* remove cpp entry

* only tests python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants