Added APIs isalnum() and isnumeric() in string object #2582
Conversation
| @@ -366,7 +366,69 @@ def is_space(): | |||
| s = "" | |||
| assert s.isspace() == False | |||
|
|
|||
| def is_alnum(): | |||
There was a problem hiding this comment.
For future, I would suggest adding changes in integration tests in a separate commit. That can/would help avoid/resolve conflicts in integration tests. If there are conflicts and you are unable to resolve them, you can simply drop the specific conflicting commit and then rebase without any conflicts. Later manually add changes for the dropped commit.
I am sharing this since you experienced some conflicts in your pervious PR #2572.
There was a problem hiding this comment.
Ok, I'll follow this from now on. Thank you.
| res6: bool = f.isalnum() | ||
| res7: bool = g.isalnum() | ||
|
|
||
| assert res == True |
There was a problem hiding this comment.
You can also print the obtained result values before the assert. That helps in debugging if there is any failure later.
There was a problem hiding this comment.
Ok, I'll add print statements. Please let me know why a particular CI check fails. It's related to PIP installable packages.
There was a problem hiding this comment.
Please let me know why a particular CI check fails. It's related to PIP installable packages.
It is probably a fluke.
There was a problem hiding this comment.
It looks good to me! Thanks for this! Amazing work @Kishan-Ved!
Thank you! I'm happy to contribute 😊. |
Towards: #2356
APIs added:
These have been tested extensively, for both compile time and run time tests.