Add `str.isspace()` method #2586

kmr-srbh · 2024-03-07T16:08:41Z

#2490 gave wrong output due to the incorrect handling of the escape sequence '\f'. Escaping the sequence was handled, but unescaping was missed. This led to the string " \t\n\v\f\r" being transformed to " \t\n\v\\f\r" in the AST. Note the extra "\" after "v". Hence, the answer in #2490 was thus 'not actually' wrong as non-whitespace and lowercase characters did exist.

Fix

def f():
    b: str = " \t\n\v\f\r"
    print(b.isspace())
    print(b.islower())
    print(b.isupper())


f()

(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
True
False
False

Improvement

Though the error in the above case was due to incorrect string handling, the isspace() method was actually not implemented correctly. The definition of a 'whitespace' character is very broad. The Python interpreter checks for all of them in it's implementation of the method. I incorporated checking for those characters.

kmr-srbh · 2024-03-07T16:09:26Z

I am adding the tests in a while. @Thirumalai-Shaktivel please see this.

src/runtime/lpython_builtin.py

Thirumalai-Shaktivel · 2024-03-09T16:21:37Z

Also, Let's add some tests.

Co-authored-by: Thirumalai Shaktivel <[email protected]>

integration_tests/test_str_attributes.py

ubaidsk · 2024-03-09T22:24:50Z

@kmr-srbh Please mark it as ready for review when ready.

Co-authored-by: Shaikh Ubaid <[email protected]>

kmr-srbh · 2024-03-10T03:48:08Z

The failing test, though unrelated, was causing disruption here. It was the one which checked for invalid literals like 01. This was fixed in a recent merged PR, so I have removed that test.

@Shaikh-Ubaid This PR is now ready. As far as the Unicode characters are concerned, they cannot be typed, but can appear when parsing strings or related work. They were added conforming to what Python calls a whitespace character.

tests/errors/test_literal.py

Thirumalai-Shaktivel · 2024-03-10T03:59:45Z

tests/reference/tokens-test_literal-e20c024.stdout

+(TOKEN "identifier" i32) 28:30
+(TOKEN "=") 32:32
+(TOKEN "integer" 123) 34:37
+(EOF) 38:38


Also, I think this file needs to be remove manually.

kmr-srbh · 2024-03-10T04:17:55Z

Problem persists. Why does ./run_tests.py -u not fix it?

tests/errors/test_literal.py

kmr-srbh · 2024-03-12T11:01:01Z

@Thirumalai-Shaktivel could you please look as to why the tests fail? The previous messages pointed to the null char I had declared for looping through the whitespace characters. I cannot understand why the tests fail now. Please guide me.

src/runtime/lpython_builtin.py

tests/reference/asr-expr8-6beda60.stderr

tests/reference/tokens-test_literal-e20c024.stdout

Thirumalai-Shaktivel

LGTM!

kmr-srbh added 4 commits March 7, 2024 12:20

Handle unescaping of \f

3a050cd

Added isspace() method implementation

c5c9e77

Revert auto-formatting changes

86663b9

Fix branch errors

55e39b0

kmr-srbh and others added 4 commits March 7, 2024 21:49

Update lpython_builtin.py

f69ebba

Update lpython_builtin.py

f56cfec

Merge branch 'main' into isspace-method

28c3e93

Update test references

504aaa0

Thirumalai-Shaktivel reviewed Mar 9, 2024

View reviewed changes

src/runtime/lpython_builtin.py Outdated Show resolved Hide resolved

kmr-srbh and others added 4 commits March 9, 2024 22:32

Minor logic change

5149ef4

Co-authored-by: Thirumalai Shaktivel <[email protected]>

Add tests

27c16ad

Update test references

7e6e8f4

Merge branch 'main' into isspace-method

c1c50ba

ubaidsk reviewed Mar 9, 2024

View reviewed changes

integration_tests/test_str_attributes.py Outdated Show resolved Hide resolved

ubaidsk marked this pull request as draft March 9, 2024 22:23

kmr-srbh and others added 5 commits March 10, 2024 08:01

Update variable names in tests

8b84118

Co-authored-by: Shaikh Ubaid <[email protected]>

Remove redundant list

e48738e

Update tests and test references

3184d12

Update test references

9d31ba5

Remove unnecesary test

dfce891

kmr-srbh marked this pull request as ready for review March 10, 2024 03:48

Thirumalai-Shaktivel reviewed Mar 10, 2024

View reviewed changes

tests/errors/test_literal.py Outdated Show resolved Hide resolved

Thirumalai-Shaktivel reviewed Mar 10, 2024

View reviewed changes

Undo deleting file

72dc26b

Thirumalai-Shaktivel reviewed Mar 10, 2024

View reviewed changes

tests/errors/test_literal.py Outdated Show resolved Hide resolved

kmr-srbh and others added 4 commits March 10, 2024 10:14

Update test references

4a073f1

Tests: Add testcase and update test references

bf71e24

Remove unnecesary variable

dafd330

Merge branch 'main' into isspace-method

2f65c62

Thirumalai-Shaktivel reviewed Mar 12, 2024

View reviewed changes

src/runtime/lpython_builtin.py Outdated Show resolved Hide resolved

Thirumalai-Shaktivel reviewed Mar 12, 2024

View reviewed changes

tests/reference/asr-expr8-6beda60.stderr Outdated Show resolved Hide resolved

Thirumalai-Shaktivel reviewed Mar 12, 2024

View reviewed changes

tests/reference/tokens-test_literal-e20c024.stdout Outdated Show resolved Hide resolved

kmr-srbh and others added 4 commits March 12, 2024 19:29

Rename char to ch

b079a5e

Tests: Fix old test and update references

35f0d64

Delete tests/reference/asr-array_02_decl-e8f6874.stderr

a610ee3

Delete unnecessary files

9767ae2

kmr-srbh requested a review from Thirumalai-Shaktivel March 12, 2024 14:51

Thirumalai-Shaktivel approved these changes Mar 14, 2024

View reviewed changes

Merge branch 'main' into isspace-method

d7f9210

Thirumalai-Shaktivel enabled auto-merge (squash) March 14, 2024 05:34

Thirumalai-Shaktivel merged commit 6325e8d into lcompilers:main Mar 14, 2024

kmr-srbh deleted the isspace-method branch March 19, 2024 05:34

ubaidsk mentioned this pull request Mar 25, 2024

Sync libasr with LFortran #2628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `str.isspace()` method #2586

Add `str.isspace()` method #2586

Uh oh!

kmr-srbh commented Mar 7, 2024

Uh oh!

kmr-srbh commented Mar 7, 2024

Uh oh!

Uh oh!

Thirumalai-Shaktivel commented Mar 9, 2024

Uh oh!

Uh oh!

ubaidsk commented Mar 9, 2024

Uh oh!

kmr-srbh commented Mar 10, 2024

Uh oh!

Uh oh!

Thirumalai-Shaktivel Mar 10, 2024

Uh oh!

kmr-srbh commented Mar 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

kmr-srbh commented Mar 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Thirumalai-Shaktivel left a comment

Uh oh!

Uh oh!

Add str.isspace() method #2586

Add str.isspace() method #2586

Uh oh!

Conversation

kmr-srbh commented Mar 7, 2024

Fix

Improvement

Uh oh!

kmr-srbh commented Mar 7, 2024

Uh oh!

Uh oh!

Thirumalai-Shaktivel commented Mar 9, 2024

Uh oh!

Uh oh!

ubaidsk commented Mar 9, 2024

Uh oh!

kmr-srbh commented Mar 10, 2024

Uh oh!

Uh oh!

Thirumalai-Shaktivel Mar 10, 2024

Choose a reason for hiding this comment

Uh oh!

kmr-srbh commented Mar 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kmr-srbh commented Mar 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Add `str.isspace()` method #2586

Add `str.isspace()` method #2586

kmr-srbh commented Mar 10, 2024 •

edited

Loading