Remove is_fast and its associated methods from PassManager
#2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2024
czgdp1807
commented
Mar 13, 2024
| apply_passes(al, asr, _user_defined_passes, pass_options, | ||
| diagnostics); | ||
| } else if( apply_default_passes ) { | ||
| pass_options.fast = is_fast; | ||
| if( is_fast ) { |
There was a problem hiding this comment.
This was wrong earlier. The user input should never be modified. In fact pass_options.fast is alone enough. is_fast was redundant.
czgdp1807
commented
Mar 13, 2024
| @@ -287,12 +286,10 @@ namespace LCompilers { | |||
| PassOptions& pass_options, | |||
| diag::Diagnostics &diagnostics) { | |||
| if( !_user_defined_passes.empty() ) { | |||
| pass_options.fast = true; | |||
There was a problem hiding this comment.
Same here. pass_options.fast should only be read from the command line and should not be set to true deliberately. This line caused bugs in LC and optimisations weren't being applied to LLVM because of such modifications of pass_options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lcompilers/lc#110
lfortran/lfortran#3646