Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for global set declaration #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 17, 2024
Merged

Add support for global set declaration #2605

merged 8 commits into from
Mar 17, 2024

Conversation

kmr-srbh
Copy link
Contributor

@kmr-srbh kmr-srbh commented Mar 14, 2024 •
edited
Loading

Fixes #2604

Working

s: set[str] = {"a", "b", "c", "a"}
s.add("d")
(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
(base) saurabh-kumar@Awadh:~/Projects/System/lpython$

ubaidsk
ubaidsk reviewed Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for this.

@ubaidsk
Copy link
Collaborator

ubaidsk commented Mar 16, 2024

Please mark it as "Ready for review" when ready.

@ubaidsk ubaidsk marked this pull request as draft March 16, 2024 21:39
@kmr-srbh kmr-srbh marked this pull request as ready for review March 17, 2024 07:24
@kmr-srbh kmr-srbh requested a review from ubaidsk March 17, 2024 07:26
ubaidsk
ubaidsk reviewed Mar 17, 2024
View reviewed changes
@ubaidsk ubaidsk marked this pull request as draft March 17, 2024 12:50
@kmr-srbh kmr-srbh marked this pull request as ready for review March 17, 2024 14:12
@kmr-srbh kmr-srbh requested a review from ubaidsk March 17, 2024 14:12
ubaidsk
ubaidsk reviewed Mar 17, 2024
View reviewed changes
ubaidsk
ubaidsk reviewed Mar 17, 2024
View reviewed changes
@ubaidsk ubaidsk marked this pull request as draft March 17, 2024 17:44
@ubaidsk ubaidsk marked this pull request as ready for review March 17, 2024 18:13
ubaidsk
ubaidsk approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks! Great work!

@ubaidsk ubaidsk enabled auto-merge (squash) March 17, 2024 18:15
@ubaidsk ubaidsk merged commit 0ba09ab into lcompilers:main Mar 17, 2024
@kmr-srbh kmr-srbh deleted the fix-global-set-declaration branch March 19, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubaidsk ubaidsk ubaidsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Global declaration of set fails
2 participants
@kmr-srbh @ubaidsk