add test reference for an error message #2623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any suggestions for the test file's name? |
Hello @aryangupta701! I think the file can be renamed to say |
ubaidsk
reviewed
Mar 24, 2024
tests/tests.toml
Outdated
| @@ -1383,3 +1383,7 @@ run_with_dbg = true | |||
| [[test]] | |||
| filename = "runtime_errors/test_raise_01.py" | |||
| run_with_dbg = true | |||
|
|
|||
| [[test]] | |||
| filename = "errors/test_optional_list.py" | |||
There was a problem hiding this comment.
We can rename it to test_optional.py. You can add this above line 1350 where you have other error tests listed.
Once you rename, make sure to delete the old reference files.
|
I request you to link this PR with the issue so that it gets closed automatically when this is merged. You can add |
c14b1bf to
1c6d657
Compare
Signed-off-by: Aryan Gupta <[email protected]>
1c6d657 to
388acb5
Compare
ubaidsk
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1953
add a test reference in order to address #1953 issue