Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed error banner from tests (#2631) #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

NishantBansal2003
Copy link
Contributor

Description:
This pull request addresses Issue #2631, which concerns the removal of the error banner from tests. The issue has been resolved by introducing the --no-error-banner flag in the extra_args parameter of the run_test function. This flag effectively disables the display of unwanted text during test execution.

Changes Made:

  • Added --no-error-banner flag to disable error banner in tests.
  • Updated run_test function to include the extra_args parameter with the --no-error-banner flag.

Testing:
I've tested these changes locally to ensure that the error banner is properly disabled during test execution. All existing tests continue to pass without any issues.

@ubaidsk ubaidsk force-pushed the error_banner_fix branch from 4bf88b9 to d47e9f1 Compare April 4, 2024 03:30
Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for this! Amazing work!

@ubaidsk ubaidsk enabled auto-merge April 4, 2024 03:31
@ubaidsk ubaidsk merged commit bd90464 into lcompilers:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants