Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement symbolic sign function #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Implement symbolic sign function #2715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
100a290
Implement symbolic sign function
anutosh491 May 24, 2024
112ba15
Implement symbolic sign function
anutosh491 May 24, 2024
b58c6e5
Merge branch 'sign' of https://github.com/anutosh491/lpython into sign
anutosh491 Jun 13, 2024
f202bf8
Added tests
anutosh491 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion integration_tests/symbolics_06.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from sympy import Symbol, sin, cos, exp, log, Abs, pi, diff
from sympy import Symbol, sin, cos, exp, log, Abs, pi, diff, sign
from lpython import S

def test_elementary_functions():
Expand All @@ -25,6 +25,13 @@ def test_elementary_functions():
assert(Abs(S(10)) == S(10))
assert(Abs(S(-1)*x) == Abs(x))

# test sign
assert(sign(S(-10)) == S(-1))
assert(sign(S(0)) == S(0))
assert(sign(S(10)) == S(1))
assert(sign(S(2)* x) == sign(x))
assert(sign(S(-1)* x) == S(-1) * sign(x))

# test composite functions
a: S = exp(x)
b: S = sin(a)
Expand Down
6 changes: 6 additions & 0 deletions src/libasr/pass/intrinsic_function_registry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ inline std::string get_intrinsic_name(int x) {
INTRINSIC_NAME_CASE(SymbolicLog)
INTRINSIC_NAME_CASE(SymbolicExp)
INTRINSIC_NAME_CASE(SymbolicAbs)
INTRINSIC_NAME_CASE(SymbolicSign)
INTRINSIC_NAME_CASE(SymbolicHasSymbolQ)
INTRINSIC_NAME_CASE(SymbolicAddQ)
INTRINSIC_NAME_CASE(SymbolicMulQ)
Expand Down Expand Up @@ -448,6 +449,8 @@ namespace IntrinsicElementalFunctionRegistry {
{nullptr, &SymbolicExp::verify_args}},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicAbs),
{nullptr, &SymbolicAbs::verify_args}},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicSign),
{nullptr, &SymbolicSign::verify_args}},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicHasSymbolQ),
{nullptr, &SymbolicHasSymbolQ::verify_args}},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicAddQ),
Expand Down Expand Up @@ -739,6 +742,8 @@ namespace IntrinsicElementalFunctionRegistry {
"SymbolicExp"},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicAbs),
"SymbolicAbs"},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicSign),
"SymbolicSign"},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicHasSymbolQ),
"SymbolicHasSymbolQ"},
{static_cast<int64_t>(IntrinsicElementalFunctions::SymbolicAddQ),
Expand Down Expand Up @@ -900,6 +905,7 @@ namespace IntrinsicElementalFunctionRegistry {
{"SymbolicLog", {&SymbolicLog::create_SymbolicLog, &SymbolicLog::eval_SymbolicLog}},
{"SymbolicExp", {&SymbolicExp::create_SymbolicExp, &SymbolicExp::eval_SymbolicExp}},
{"SymbolicAbs", {&SymbolicAbs::create_SymbolicAbs, &SymbolicAbs::eval_SymbolicAbs}},
{"SymbolicSign", {&SymbolicSign::create_SymbolicSign, &SymbolicSign::eval_SymbolicSign}},
{"has", {&SymbolicHasSymbolQ::create_SymbolicHasSymbolQ, &SymbolicHasSymbolQ::eval_SymbolicHasSymbolQ}},
{"AddQ", {&SymbolicAddQ::create_SymbolicAddQ, &SymbolicAddQ::eval_SymbolicAddQ}},
{"MulQ", {&SymbolicMulQ::create_SymbolicMulQ, &SymbolicMulQ::eval_SymbolicMulQ}},
Expand Down
2 changes: 2 additions & 0 deletions src/libasr/pass/intrinsic_functions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ enum class IntrinsicElementalFunctions : int64_t {
SymbolicLog,
SymbolicExp,
SymbolicAbs,
SymbolicSign,
SymbolicHasSymbolQ,
SymbolicAddQ,
SymbolicMulQ,
Expand Down Expand Up @@ -5968,6 +5969,7 @@ create_symbolic_unary_macro(SymbolicCos)
create_symbolic_unary_macro(SymbolicLog)
create_symbolic_unary_macro(SymbolicExp)
create_symbolic_unary_macro(SymbolicAbs)
create_symbolic_unary_macro(SymbolicSign)
create_symbolic_unary_macro(SymbolicExpand)

} // namespace LCompilers::ASRUtils
Expand Down
1 change: 1 addition & 0 deletions src/libasr/pass/replace_symbolic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
BASIC_UNARYOP(Log, log)
BASIC_UNARYOP(Exp, exp)
BASIC_UNARYOP(Abs, abs)
BASIC_UNARYOP(Sign, sign)
BASIC_UNARYOP(Expand, expand)
BASIC_TERNARYOP(Subs, subs2)
case LCompilers::ASRUtils::IntrinsicElementalFunctions::SymbolicGetArgument: {
Expand Down
4 changes: 2 additions & 2 deletions src/lpython/semantics/python_ast_to_asr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7677,7 +7677,7 @@ we will have to use something else.
};
if (symbolic_attributes.find(at->m_attr) != symbolic_attributes.end()){
std::set<std::string> symbolic_functions = {
"sin", "cos", "log", "exp", "Abs", "Symbol"
"sin", "cos", "log", "exp", "Abs", "sign", "Symbol"
};
if (AST::is_a<AST::Attribute_t>(*call->m_func)) {
visit_Call(*call);
Expand Down Expand Up @@ -7809,7 +7809,7 @@ we will have to use something else.
"sum" // For sum called over lists
};
std::set<std::string> symbolic_functions = {
"sin", "cos", "log", "exp", "Abs"
"sin", "cos", "log", "exp", "Abs", "sign"
};
if ((symbolic_functions.find(call_name) != symbolic_functions.end()) &&
imported_functions[call_name] == "sympy"){
Expand Down
Loading