Thanks to visit codestin.com
Credit goes to github.com

fix: never use a log message as a format string #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

leejet merged 1 commit into leejet:master from Green-Sky:fix_cli_log_format_risk

Jan 1, 2024

Contributor

Green-Sky commented Jan 1, 2024

Users could inject formatters and crash the application.
Also does not compile with my setup:

/examples/cli/main.cpp:463:16: error: format not a string literal and no format arguments [-Werror=format-security]
  463 |         fprintf(stdout, log);


          fix: never use a log message as a format string

24452f8

leejet merged commit 4a5e7b5 into leejet:master

Green-Sky deleted the fix_cli_log_format_risk branch

November 23, 2024 12:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet