Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add convert api #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2024
Merged

feat: add convert api #142

merged 4 commits into from
Jan 14, 2024

Conversation

leejet
Copy link
Owner

@leejet leejet commented Jan 4, 2024

No description provided.

@Cyberhan123
Copy link
Contributor

Cyberhan123 commented Jan 6, 2024

@leejet Due to the API refactor, I think I don't need to add additional package code (I mean this project https://github.com/seasonjs/stable-diffusion.cpp-build). Are you willing to let github ci support building dynamic libraries? If you are willing, I am willing to modify ci and submit a PR.
Below is my planned dynamic library compatibility table:

platform x32 x64 arm AMD/ROCM NVIDIA/CUDA
windows not support support avx/avx2/avx512 not support rocm5.5 support cuda12 support
linux not support support not support not support not support
darwin not support support support not support not support

@Green-Sky
Copy link
Contributor

@Cyberhan123 is there a point in not using avx2 for linux/mac amd64 ?

@Cyberhan123
Copy link
Contributor

@Cyberhan123 is there a point in not using avx2 for linux/mac amd64 ?

Only supports avx2

@Green-Sky
Copy link
Contributor

@leejet would be cool if we could bake in a custom vae, like the f16 fix for xl.

@Jonathhhan
Copy link

Only supports avx2

I use avx2 and CUDA with Linux.

@leejet
Copy link
Owner Author

leejet commented Jan 8, 2024

Are you willing to let github ci support building dynamic libraries?

@Cyberhan123 I'd appreciate someone helping to set up the corresponding CI. I haven't had much free time lately to work on this.

@leejet
Copy link
Owner Author

leejet commented Jan 8, 2024

@leejet would be cool if we could bake in a custom vae, like the f16 fix for xl.

I'm not quite following what you mean. It's been possible to specify custom vae for a while now.

@Green-Sky
Copy link
Contributor

@leejet would be cool if we could bake in a custom vae, like the f16 fix for xl.

I'm not quite following what you mean. It's been possible to specify custom vae for a while now.

but to have them merged/replaced into the same gguf

@leejet
Copy link
Owner Author

leejet commented Jan 9, 2024

@leejet would be cool if we could bake in a custom vae, like the f16 fix for xl.

I'm not quite following what you mean. It's been possible to specify custom vae for a while now.

but to have them merged/replaced into the same gguf

It has been supported now.

.\bin\Release\sd.exe -M convert -m ..\..\stable-diffusion-webui\models\Stable-diffusion\sd_xl_base_1.0.safetensors --vae ..\..\stable-diffusion-webui\models\VAE\sdxl_vae-fp16-fix.safetensors -o ..\models\sd_xl_base_1.0_with_vae_fix.gguf -v
.\bin\Release\sd.exe -m ..\models\sd_xl_base_1.0_with_vae_fix.gguf -p "a lovely cat" -v   -H 1024 -W 1024

@Cyberhan123
Copy link
Contributor

I'd appreciate someone helping to set up the corresponding CI. I haven't had much free time lately to work on this.

Okay, after ggml is merged and the PR of rocm is completed, I will implement it.

@leejet leejet merged commit 5c614e4 into master Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants