Prepare challtestsrv for DNS-persist challenge support#32
Merged
Conversation
Member
Author
|
If we want to more gracefully deprecate some or all of these APIs I'm open to adding some wrappers that can be removed at a later date. |
jsha
approved these changes
Feb 9, 2026
beautifulentropy
added a commit
to letsencrypt/pebble
that referenced
this pull request
Feb 10, 2026
Prepare challtestsrv for the addition of a new DNS-based challenge method, [draft-ietf-acme-dns-persist](https://datatracker.ietf.org/doc/html/draft-ietf-acme-dns-persist-00). Overall functionality is unchanged aside from the API changes documented below; these changes are purely terminology updates and code reorganization. Update challtestsrv to v1.4.1, a tag that includes letsencrypt/challtestsrv#32. In pebble-challtestsrv, merge dnsone.go and mockdns.go into dns.go, and rename DNS-01-specific functions to the more generic DNS*. Rename the `-dns01` flag to `-dnsserver`, matching the same flag in Pebble. Also, remove any mention of mock, mocks, and mocked in the dns.go doc comments and README.
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare challtestsrv for the addition of a new DNS-based challenge method, draft-ietf-acme-dns-persist. Overall functionality is unchanged aside from the API changes documented below; these changes are purely terminology updates and code reorganization.
Rename DNS-01-specific APIs to generic DNS APIs, move TXT records into unified dnsData, and update docs/comments from DNSOne* to DNS*. Note: there are four breaking API changes introduced by this change:
Remove “mock” terminology, merge mockdns.go into dns.go, and update docs/comments accordingly. There are three breaking API changes introduced by this change: