eve-k + pillar: Fix mount points for Nvidia#5284
Merged
Merged
Conversation
The /etc/cdi and /opt/vendor directories should also be visible (mounted) on pkg/kube and pkg/pillar for kubevirt variant. Signed-off-by: Renê de Souza Pinto <[email protected]>
The /etc/cdi and /opt/vendor directories should also be visible (mounted) for build-dev.yml and build-rstats.yml on pillar as well. Signed-off-by: Renê de Souza Pinto <[email protected]>
OhmSpectator
approved these changes
Oct 6, 2025
OhmSpectator
left a comment
Member
There was a problem hiding this comment.
Fine. But why wasn’t it caught earlier? I have some doubts about how the KubeVirt variant is being tested.
Contributor
Author
@OhmSpectator , I think kubevirt is not tested on arm64. These mount points will be really needed only for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
/etc/cdiand/opt/vendordirectories should also be visible (mounted) for all pillar variants + eve-k in order to get access to Nvidia libraries + CDI yaml files. These mount points were missing for:How to test and validate this PR
These mount points are not in current use for the versions that they were added by this PR. So I don't think we need a strict validation at this moment. However, it can still be checked by building the different combinations for EVE + nvidia, for instance:
make ZARCH=arm64 PLATFORM=nvidia-jp6 DEV=1 ...make ZARCH=arm64 HV=k PLATFORM=nvidia-jp6 ...Then, by entering inside the containers (pillar and kube) and checking if the Nvidia files are there. For instance:
Changelog notes
Add Nvidia mount points for eve-k and pkg/pillar dev. variants.
PR Backports
These mount points were not in use by eve-k for previous versions, so there is no need to backport.
Checklist
check them.