Detect and report unpushed Linux kernel tags in update_kernel_commits.py#5286
Merged
Merged
Conversation
d5adebb to
8243f73
Compare
a36846e to
77c8fef
Compare
…commits.py Add validation to detect when referenced commits are not found in the repository, with special handling for Linux kernel tags. Changes: - Add LinuxKernelTagNotPushedError exception for distinguishable error handling - Check if old_commit exists in repository before fetching commit range - Detect Linux kernel tag format (vX.Y.Z) and provide helpful hint message - Continue processing all branches instead of stopping at first error - Collect all missing commit errors and report them together at the end - Format error output with prominent "ERROR:" prefix and branch name - Exit with error code 1 when any commits are not found This prevents the script from proceeding with invalid data and ensures all unpushed tags are reported in a single run, making it easier for users to identify and fix all issues at once. Example output: ERROR: eve-kernel-amd64-v6.12.49-generic: commit 'v6.12.49' is not found in the repository. This appears to be a Linux kernel tag (vX.Y.Z format) that must be pushed to the repository first. Signed-off-by: Mikhail Malyshev <[email protected]>
77c8fef to
b92b59d
Compare
OhmSpectator
approved these changes
Oct 6, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add validation to detect when referenced commits are not found in the
repository, with special handling for Linux kernel tags.
Changes:
This prevents the script from proceeding with invalid data and ensures
all unpushed tags are reported in a single run, making it easier for
users to identify and fix all issues at once.
Example output:
ERROR: eve-kernel-amd64-v6.12.49-generic: commit 'v6.12.49' is not
found in the repository. This appears to be a Linux kernel tag
(vX.Y.Z format) that must be pushed to the repository first.
How to test and validate this PR
not easy, you need to have a newly pushed branch. @rene has one right now and can validate it
Changelog notes
None
PR Backports
Not requires because we do not introduce new kernels on old branches
Checklist
And the last but not least:
check them.