eve persist on second disk fix: don't init P3 partition#5289
Conversation
|
I tested the fix and it works. |
|
@andrewd-zededa @zedi-pramodh did you test PLATFORM=evaluation? this change breaks it |
rucoder
left a comment
There was a problem hiding this comment.
on EVAL eve all partitions are initialized so this condition must be adjusted for both cases
Ok, my original private message was asking about this. I guess this needs to be reworked to handle both situations. |
f36a84a to
4b73364
Compare
|
I've amended the commit to attempt to handle all three conditions:
I'm working through testing this latest change. |
|
@andrewd-zededa , just found a minor thing, otherwise LGTM.... I'll wait for @rucoder's comment as well... |
Its possible that P3 is not initialized if the EVE installer was configured to use a zfs persist on 1 or more separate disks. eg. eve_install_disk=sda eve_persist_disk=sdb. Condition was originally amended for Eval EVE in this commit: 7b9076f. Attempt to formalize the two conditions expected here and document the possible zfs condition. Signed-off-by: Andrew Durbin <[email protected]>
4b73364 to
8e13f5f
Compare
|
The evaluation build is red but its due to this:
|
|
/rerun red |
|
Looks like I have permissions to merge, can I exercise my power :) |
Description
For eve installs where the persist filesystem is placed on a separate disk: storage-init will not detect a P3 PARTLABEL on the install disk so the IMGA variable will be set and P3 will be empty. Use the IMGB empty or IMGC not empty as a way to detect this is an uninitialized system. Allow storage-init to fall to line 252
#in case of no P3 we may have EVE persist on another diskswhere the zpool import will occur.PR dependencies
None
How to test and validate this PR
Changelog notes
Fix EVE install where persist is placed on a second disk.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.