Makefile: Fix eve-k build for nvidia-jp6#5308
Merged
Merged
Conversation
Makefile is not taking into account build-<PLATFORM>.yml files when HV=k. For example: make ZARCH=arm64 HV=k PLATFORM=nvidia-jp6 pkg/nvidia Should build pkg/nvidia for nvidia-jp6 platform, but currently it uses build.yml, which builds for nvidia-jp5. This commit fixes this issue. Signed-off-by: Renê de Souza Pinto <[email protected]>
eriknordmark
left a comment
Contributor
There was a problem hiding this comment.
Is this bug a new/regression due to changin the kubvirt -> k name, or has the bug been there for a while?
Contributor
Author
I wish I could blame you @eriknordmark 😆 but I can't... the bug was there since 14.5, that's why I will backport it as well... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makefile is not taking into account
build-<PLATFORM>.ymlfiles whenHV=k. For example:make ZARCH=arm64 HV=k PLATFORM=nvidia-jp6 pkg/nvidiaShould build pkg/nvidia for nvidia-jp6 platform, but currently it uses build.yml, which builds for nvidia-jp5. This commit fixes this issue.
How to test and validate this PR
Run:
make ZARCH=arm64 HV=k PLATFORM=nvidia-jp6 pkg/nvidiaEnsure is going to build
pkg/nvidiafornvidia-jp6, notnvidia-jp5.Changelog notes
Fix platform build variants for eve-k.
PR Backports
Checklist
check them.